]> git.itanic.dy.fi Git - linux-stable/commitdiff
cpufreq: mediatek-hw: Don't error out if supply is not found
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Wed, 24 Jan 2024 20:31:43 +0000 (17:31 -0300)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:16:34 +0000 (18:16 -0400)
[ Upstream commit eaffb10b51bf74415c9252fd8fb4dd77122501ee ]

devm_regulator_get_optional() returns -ENODEV if no supply can be found.
By introducing its usage, commit 788715b5f21c ("cpufreq: mediatek-hw:
Wait for CPU supplies before probing") caused the driver to fail probe
if no supply was present in any of the CPU DT nodes.

Use devm_regulator_get() instead since the CPUs do require supplies
even if not described in the DT. It will gracefully return a dummy
regulator if none is found in the DT node, allowing probe to succeed.

Fixes: 788715b5f21c ("cpufreq: mediatek-hw: Wait for CPU supplies before probing")
Reported-by: kernelci.org bot <bot@kernelci.org>
Closes: https://linux.kernelci.org/test/case/id/65b0b169710edea22852a3fa/
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/cpufreq/mediatek-cpufreq-hw.c

index a1aa9385980ae0f53c826259ed15c0fa882e3eb8..8d097dcddda47df298a6ceba2f92dfd5e27c6cb8 100644 (file)
@@ -312,7 +312,7 @@ static int mtk_cpufreq_hw_driver_probe(struct platform_device *pdev)
                        return dev_err_probe(&pdev->dev, -EPROBE_DEFER,
                                             "Failed to get cpu%d device\n", cpu);
 
-               cpu_reg = devm_regulator_get_optional(cpu_dev, "cpu");
+               cpu_reg = devm_regulator_get(cpu_dev, "cpu");
                if (IS_ERR(cpu_reg))
                        return dev_err_probe(&pdev->dev, PTR_ERR(cpu_reg),
                                             "CPU%d regulator get failed\n", cpu);