]> git.itanic.dy.fi Git - linux-stable/commitdiff
mmc: wmt-sdmmc: remove an incorrect release_mem_region() call in the .remove function
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 26 Feb 2024 21:37:39 +0000 (22:37 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:16:51 +0000 (18:16 -0400)
[ Upstream commit ae5004a40a262d329039b99b62bd3fe7645b66ad ]

This looks strange to call release_mem_region() in a remove function
without any request_mem_region() in the probe or "struct resource"
somewhere.

So remove the corresponding code.

Fixes: 3a96dff0f828 ("mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/bb0bb1ed1e18de55e8c0547625bde271e64b8c31.1708983064.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/wmt-sdmmc.c

index 77d5f1d244899f32fa396a70d946db92ff579cc8..860380931b6cde736a9e57ccdaee20e877c0b182 100644 (file)
@@ -883,7 +883,6 @@ static void wmt_mci_remove(struct platform_device *pdev)
 {
        struct mmc_host *mmc;
        struct wmt_mci_priv *priv;
-       struct resource *res;
        u32 reg_tmp;
 
        mmc = platform_get_drvdata(pdev);
@@ -911,9 +910,6 @@ static void wmt_mci_remove(struct platform_device *pdev)
        clk_disable_unprepare(priv->clk_sdmmc);
        clk_put(priv->clk_sdmmc);
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       release_mem_region(res->start, resource_size(res));
-
        mmc_free_host(mmc);
 
        dev_info(&pdev->dev, "WMT MCI device removed\n");