]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: dsa: lantiq_gswip: delete irrelevant use of ds->phys_mii_mask
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 4 Jan 2024 14:00:28 +0000 (16:00 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Jan 2024 11:56:35 +0000 (11:56 +0000)
__of_mdiobus_register(), called right next, overwrites the phy_mask
we just configured on the bus, so this is redundant and confusing.
Delete it.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/lantiq_gswip.c

index 05a017c9ef3db74a4ade18e99e613297ca99762e..3494ad854cf61314edb7166f1d7c84e340d0c6a0 100644 (file)
@@ -521,7 +521,6 @@ static int gswip_mdio(struct gswip_priv *priv, struct device_node *mdio_np)
        snprintf(ds->user_mii_bus->id, MII_BUS_ID_SIZE, "%s-mii",
                 dev_name(priv->dev));
        ds->user_mii_bus->parent = priv->dev;
-       ds->user_mii_bus->phy_mask = ~ds->phys_mii_mask;
 
        err = of_mdiobus_register(ds->user_mii_bus, mdio_np);
        if (err)