]> git.itanic.dy.fi Git - linux-stable/commitdiff
media: staging: starfive: camss: fix off by one in isp_enum_mbus_code()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 28 Nov 2023 14:40:14 +0000 (17:40 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 7 Dec 2023 07:31:14 +0000 (08:31 +0100)
These > comparisons should be >=.  The formats->fmts[] array is either
a pointer to isp_formats_sink[] or isp_formats_source[] respectively.

Fixes: e57854628f58 ("media: staging: media: starfive: camss: Add ISP driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/staging/media/starfive/camss/stf-isp.c

index 6bffffb2b20c5fa62d9112ab1a2eff5f20e868f1..d50616ef351ed30b24aacf43e3f47b890f625ae0 100644 (file)
@@ -120,7 +120,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
        const struct stf_isp_format_table *formats;
 
        if (code->pad == STF_ISP_PAD_SINK) {
-               if (code->index > ARRAY_SIZE(isp_formats_sink))
+               if (code->index >= ARRAY_SIZE(isp_formats_sink))
                        return -EINVAL;
 
                formats = &isp_dev->formats[SINK_FORMATS_INDEX];
@@ -128,7 +128,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
        } else {
                struct v4l2_mbus_framefmt *sink_fmt;
 
-               if (code->index > ARRAY_SIZE(isp_formats_source))
+               if (code->index >= ARRAY_SIZE(isp_formats_source))
                        return -EINVAL;
 
                sink_fmt = v4l2_subdev_state_get_format(state,