]> git.itanic.dy.fi Git - linux-stable/commitdiff
net/mlx4_en: Initialize RFS filters lock and list in init_netdev
authorAmir Vadai <amirv@mellanox.com>
Thu, 24 Jan 2013 01:54:19 +0000 (01:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Mar 2013 20:10:57 +0000 (13:10 -0700)
commit 78fb2de711ec28997bf38bcf3e48e108e907be77 upstream.

filters_lock might have been used while it was re-initialized.
Moved filters_lock and filters_list initialization to init_netdev instead of
alloc_resources which is called every time the device is configured.

Signed-off-by: Amir Vadai <amirv@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/mellanox/mlx4/en_netdev.c

index 88291bbdd24a985d91defdd6ef8f525ada041fb5..17a14c1f56c2d27ac5fda680c52e581d034dde30 100644 (file)
@@ -1437,9 +1437,6 @@ int mlx4_en_alloc_resources(struct mlx4_en_priv *priv)
        priv->dev->rx_cpu_rmap = alloc_irq_cpu_rmap(priv->mdev->dev->caps.comp_pool);
        if (!priv->dev->rx_cpu_rmap)
                goto err;
-
-       INIT_LIST_HEAD(&priv->filters);
-       spin_lock_init(&priv->filters_lock);
 #endif
 
        return 0;
@@ -1634,6 +1631,11 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
        if (err)
                goto out;
 
+#ifdef CONFIG_RFS_ACCEL
+       INIT_LIST_HEAD(&priv->filters);
+       spin_lock_init(&priv->filters_lock);
+#endif
+
        /* Allocate page for receive rings */
        err = mlx4_alloc_hwq_res(mdev->dev, &priv->res,
                                MLX4_EN_PAGE_SIZE, MLX4_EN_PAGE_SIZE);