]> git.itanic.dy.fi Git - linux-stable/commitdiff
ext4: drop read-only check in ext4_init_inode_table()
authorJan Kara <jack@suse.cz>
Fri, 16 Jun 2023 16:50:54 +0000 (18:50 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 29 Jul 2023 22:37:53 +0000 (18:37 -0400)
We better should not be initializing inode tables on read-only
filesystem. The following transaction start will warn us and make the
function bail anyway so drop the pointless check.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230616165109.21695-8-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/ialloc.c

index 060630c0b0ca08eaaf024128cdebe7a20334a840..e0698f54e17ae3a7ee1fdbc17c6742baef9988f0 100644 (file)
@@ -1523,12 +1523,6 @@ int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
        int num, ret = 0, used_blks = 0;
        unsigned long used_inos = 0;
 
-       /* This should not happen, but just to be sure check this */
-       if (sb_rdonly(sb)) {
-               ret = 1;
-               goto out;
-       }
-
        gdp = ext4_get_group_desc(sb, group, &group_desc_bh);
        if (!gdp || !grp)
                goto out;