]> git.itanic.dy.fi Git - linux-stable/commitdiff
drm/xe/device: clean up on error in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 5 Jan 2024 12:22:23 +0000 (15:22 +0300)
committerThomas Hellström <thomas.hellstrom@linux.intel.com>
Mon, 15 Jan 2024 14:36:55 +0000 (15:36 +0100)
This error path should clean up before returning.

Smatch detected this bug:
  drivers/gpu/drm/xe/xe_device.c:487 xe_device_probe() warn: missing unwind goto?

Fixes: 4cb12b71923b ("drm/xe/xe2: Determine bios enablement for flat ccs on igfx")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
(cherry picked from commit c10da95afa68060e13c5f920d96671943a7e54d9)
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
drivers/gpu/drm/xe/xe_device.c

index d9ae77fe7382ddf9997858995fe255108f7c5944..b8d8da5466708c6903ccb3ade3852a7ac9911235 100644 (file)
@@ -484,7 +484,7 @@ int xe_device_probe(struct xe_device *xe)
 
        err = xe_device_set_has_flat_ccs(xe);
        if (err)
-               return err;
+               goto err_irq_shutdown;
 
        err = xe_mmio_probe_vram(xe);
        if (err)