]> git.itanic.dy.fi Git - linux-stable/commitdiff
drm/bridge: tc358767: Add of_node_put() when breaking out of loop
authorLiang He <windhl@126.com>
Tue, 19 Jul 2022 06:54:47 +0000 (14:54 +0800)
committerRobert Foss <robert.foss@linaro.org>
Tue, 19 Jul 2022 12:48:48 +0000 (14:48 +0200)
In tc_probe_bridge_endpoint(), we should call of_node_put() when
breaking out of the for_each_endpoint_of_node() which will automatically
increase and decrease the refcount.

Fixes: 71f7d9c03118 ("drm/bridge: tc358767: Detect bridge mode from connected endpoints in DT")
Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220719065447.1080817-2-windhl@126.com
drivers/gpu/drm/bridge/tc358767.c

index 02bd757a89874acc36d43ec3ed82a9e701ec432b..1dc107f13645b23fca370f527e0c89b98ef8bb4c 100644 (file)
@@ -2010,9 +2010,10 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc)
 
        for_each_endpoint_of_node(dev->of_node, node) {
                of_graph_parse_endpoint(node, &endpoint);
-               if (endpoint.port > 2)
+               if (endpoint.port > 2) {
+                       of_node_put(node);
                        return -EINVAL;
-
+               }
                mode |= BIT(endpoint.port);
        }