drm/amd/display: Add Z8 allow states to z-state support list

[ Upstream commit 80676936805e46c79c38008e5142a77a1b2f2dc7 ]

[Why]
Even if we block Z9 based on crossover threshold it's possible to
allow for Z8.

[How]
There's support for this on DCN314, so update the support types to
include a z8 only and z8_z10 only state.

Update the decide_zstate_support function to allow for specifying
these modes based on the Z8 threshold.

DCN31 has z-state disabled, but still update the legacy code to
map z8_only = disallow and z10_z8_only = z10_only to keep the support
the same.

Reviewed-by: Jun Lei <Jun.Lei@amd.com>
Acked-by: Brian Chang <Brian.Chang@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Stable-dep-of: d893f39320e1 ("drm/amd/display: Lowering min Z8 residency time")
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c
index 090b2c02aee17a134455774dc23885b01c669ace..0827c7df28557920d6bd34adf4aa1b7aafef071f 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c
@@ -333,8 +333,8 @@ void dcn31_smu_set_zstate_support(struct clk_mgr_internal *clk_mgr, enum dcn_zst
                        (support == DCN_ZSTATE_SUPPORT_ALLOW_Z10_ONLY))
                support = DCN_ZSTATE_SUPPORT_DISALLOW;
 
-
-       if (support == DCN_ZSTATE_SUPPORT_ALLOW_Z10_ONLY)
+       if (support == DCN_ZSTATE_SUPPORT_ALLOW_Z10_ONLY ||
+           support == DCN_ZSTATE_SUPPORT_ALLOW_Z8_Z10_ONLY)
                param = 1;
        else
                param = 0;

diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
index aa264c600408d52b7ba0a43c2ffbf5115e3501bb..0765334f0825985811d8a3cf9997034c0db0c291 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
@@ -349,8 +349,6 @@ void dcn314_smu_set_zstate_support(struct clk_mgr_internal *clk_mgr, enum dcn_zs
        if (!clk_mgr->smu_present)
                return;
 
-       // Arg[15:0] = 8/9/0 for Z8/Z9/disallow -> existing bits
-       // Arg[16] = Disallow Z9 -> new bit
        switch (support) {
 
        case DCN_ZSTATE_SUPPORT_ALLOW:
@@ -369,6 +367,16 @@ void dcn314_smu_set_zstate_support(struct clk_mgr_internal *clk_mgr, enum dcn_zs
                param = (1 << 10);
                break;
 
+       case DCN_ZSTATE_SUPPORT_ALLOW_Z8_Z10_ONLY:
+               msg_id = VBIOSSMC_MSG_AllowZstatesEntry;
+               param = (1 << 10) | (1 << 8);
+               break;
+
+       case DCN_ZSTATE_SUPPORT_ALLOW_Z8_ONLY:
+               msg_id = VBIOSSMC_MSG_AllowZstatesEntry;
+               param = (1 << 8);
+               break;
+
        default: //DCN_ZSTATE_SUPPORT_UNKNOWN
                msg_id = VBIOSSMC_MSG_AllowZstatesEntry;
                param = 0;

diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index 8757d7ff8ff62b10f489bbf3e3bf9dacd2b41077..6d64d3b0dc2115d08ec009c2acf26604e2695190 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -491,6 +491,8 @@ enum dcn_pwr_state {
 enum dcn_zstate_support_state {
        DCN_ZSTATE_SUPPORT_UNKNOWN,
        DCN_ZSTATE_SUPPORT_ALLOW,
+       DCN_ZSTATE_SUPPORT_ALLOW_Z8_ONLY,
+       DCN_ZSTATE_SUPPORT_ALLOW_Z8_Z10_ONLY,
        DCN_ZSTATE_SUPPORT_ALLOW_Z10_ONLY,
        DCN_ZSTATE_SUPPORT_DISALLOW,
 };

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
index 602e885ed52c40aad92bd00e14a786234fbce119..feef0a75878f9e22d2ea1c1aee88820ae76c4be3 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.c
@@ -949,6 +949,7 @@ static enum dcn_zstate_support_state  decide_zstate_support(struct dc *dc, struc
        int plane_count;
        int i;
        unsigned int optimized_min_dst_y_next_start_us;
+       bool allow_z8 = context->bw_ctx.dml.vba.StutterPeriod > 1000.0;
 
        plane_count = 0;
        optimized_min_dst_y_next_start_us = 0;
@@ -963,6 +964,8 @@ static enum dcn_zstate_support_state  decide_zstate_support(struct dc *dc, struc
         *      2. single eDP, on link 0, 1 plane and stutter period > 5ms
         * Z10 only cases:
         *      1. single eDP, on link 0, 1 plane and stutter period >= 5ms
+        * Z8 cases:
+        *      1. stutter period sufficient
         * Zstate not allowed cases:
         *      1. Everything else
         */
@@ -990,11 +993,14 @@ static enum dcn_zstate_support_state  decide_zstate_support(struct dc *dc, struc
                if (context->bw_ctx.dml.vba.StutterPeriod > 5000.0 || optimized_min_dst_y_next_start_us > 5000)
                        return DCN_ZSTATE_SUPPORT_ALLOW;
                else if (link->psr_settings.psr_version == DC_PSR_VERSION_1 && !link->panel_config.psr.disable_psr)
-                       return DCN_ZSTATE_SUPPORT_ALLOW_Z10_ONLY;
+                       return allow_z8 ? DCN_ZSTATE_SUPPORT_ALLOW_Z8_Z10_ONLY : DCN_ZSTATE_SUPPORT_ALLOW_Z10_ONLY;
                else
-                       return DCN_ZSTATE_SUPPORT_DISALLOW;
-       } else
+                       return allow_z8 ? DCN_ZSTATE_SUPPORT_ALLOW_Z8_ONLY : DCN_ZSTATE_SUPPORT_DISALLOW;
+       } else if (allow_z8) {
+               return DCN_ZSTATE_SUPPORT_ALLOW_Z8_ONLY;
+       } else {
                return DCN_ZSTATE_SUPPORT_DISALLOW;
+       }
 }
 
 void dcn20_calculate_dlg_params(