]> git.itanic.dy.fi Git - linux-stable/commitdiff
ext4: drop read-only check in ext4_write_inode()
authorJan Kara <jack@suse.cz>
Fri, 16 Jun 2023 16:50:55 +0000 (18:50 +0200)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 29 Jul 2023 22:37:53 +0000 (18:37 -0400)
We should not have dirty inodes on read-only filesystem. Also silently
bailing without writing anything would be a problem when we enable
quotas during remount while the filesystem is read-only. So drop the
read-only check.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230616165109.21695-9-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inode.c

index 100c3ec6da6c682a8ec1a568b8584969dc89637f..1b9003840bc16c5c55cad71532d95a419bbd1b5d 100644 (file)
@@ -5129,8 +5129,7 @@ int ext4_write_inode(struct inode *inode, struct writeback_control *wbc)
 {
        int err;
 
-       if (WARN_ON_ONCE(current->flags & PF_MEMALLOC) ||
-           sb_rdonly(inode->i_sb))
+       if (WARN_ON_ONCE(current->flags & PF_MEMALLOC))
                return 0;
 
        if (unlikely(ext4_forced_shutdown(inode->i_sb)))